esciencecenter-digital-skills / training-infrastructure

collection of files used in setting up the new training infrastructure
Apache License 2.0
0 stars 0 forks source link

'get_comms_doc_info' should return lesson material url #29

Closed svenvanderburg closed 1 year ago

svenvanderburg commented 1 year ago

In order to solve https://github.com/esciencecenter-digital-skills/template-docs-coordination/issues/4, we need get_comms_doc_info to return also the lesson material url (i.e. https://carpentries-incubator.github.io/deep-learning-intro/). Not that this is not the lesson material github repo, but the actual github pages that belong to it.

bvreede commented 1 year ago

The actual URL seems to be an error with the workshop metadata: get_comms_doc_info simply returns the link that was written in the workshop metadata repository, so if links are referred to the github repo instead of the web page, this needs to be fixed per curriculum.

The broken syntax in the comms doc was due to a problem in the template. It has been fixed here and here.