Open bvreede opened 1 year ago
Hi @bvreede. I'll be unavailable until at least early September.
@liekelotte and @bvreede what's the status here?
@liekelotte can you try removing and reinstalling Microsoft365? That did the trick for me. If necessary, authenticate first (sometimes the browser needs to be activated first).
Try:
remove.packages("Microsoft365R")
install.packages("Microsoft365R")
Microsoft365R::get_team("Instructors")
This PR adds more flexibility to finding the team member from the name in the holy excel sheet. Not all names in the sheet match the person's Microsoft name (e.g. extra spaces between first and last name, missing accents, or what have you). Here I'm adding very basic "fuzzy" matching, which accepts a max Levenshtein distance of 4 between a name in the list of members from the Instructors Team on MS, and the name as given by the Holy Excel sheet.
The other functionality this adds, is that if there is no Microsoft name found that clearly matches with the Holy Excel name, this is reported; a training coordinator can now manually alert this person on Teams.
Test the workflow (sorry, poor R packaging channel) as follows:
This should make a post in the channel for 2023-03-08-ds-rpackaging (confirm the channel by running
old_r_workshop$slug
) that calls both Laura and Giulia. You should also get a message in the console that their names are not in the Microsoft teams list, but that a close match was found.(Laura and Giulia were the names that initally were reported not to be alerted; see #53.)
Fixes #53