search

escopecz / grav-ganalytics

Google Analytics plugin for Grav CMS
MIT License
20 stars 9 forks source link

Add GA4 support #34

Closed ViliusS closed 1 year ago

ViliusS commented 1 year ago

Initial GA4 support. Still working on some stuff.

utagawal commented 1 year ago

Any chance to get it fixed & merged ?

escopecz commented 1 year ago

This is just a draft so I expect this is work in progress. Once this PR is read and will have a couple of approvals that it's well tested and ready to go then I'll merge it and release a new version.

ViliusS commented 1 year ago

@utagawal you can try the latest code from this PR branch. It should fully work with one exception - some old setting values get reset because of this Grav bug https://github.com/getgrav/grav/issues/3697. Sadly there is no feedback on Grav side on that bug, so this PR is also stuck, unless someone finds a better way to transfer those settings.

ViliusS commented 1 year ago

@escopecz PR is finished, tested in production. Sadly mentioned Grav bug still doesn't allow to migrate deprecated settings automatically, but since Universal Analytics cut-off date is just around the corner I think you can release v2.0. I have added a note to README that one needs to migrate deprecated settings manually after the upgrade.

escopecz commented 1 year ago

@ViliusS I've also added you as a collaborator to this repo so feel free to merge other PRs and make a release.