Debugging + Renaming the ga object

escopecz / grav-ganalytics

Google Analytics plugin for Grav CMS

MIT License

20 stars 9 forks source link

Debugging + Renaming the ga object #7

Closed cworreschk closed 7 years ago

cworreschk commented 7 years ago

Hi John,

I've implemented two new features:

Enabling the debug mode mit trace debugging (https://developers.google.com/analytics/devguides/collection/analyticsjs/debugging)
Renaming the Global (ga) Object (https://developers.google.com/analytics/devguides/collection/analyticsjs/renaming-the-ga-object)

It would be nice, if you could update the plugin in the Grav Plugin Repository too :+1:

Thank you very much :sunglasses:

escopecz commented 7 years ago

Thanks! It looks damn good!

Could you change the indentation to 4 spaces? I couldn't find any Grav Coding Standards, but I suppose they use the same as Symfony (http://symfony.com/doc/current/contributing/code/standards.html)
How do I update the repository? The repository links to this GitHub repo, doesn't it?

cworreschk commented 7 years ago

Sorry about the indentation. In PHPStorm I have the Drupal Coding Standand configured :sunglasses: It's fixed with d51a84596a5540dc919c9c45f60c4f30b9b4d08e

Maybe the repository looks, if there s a new version in blueprints.yaml or here at Releases. We will see :smile:

escopecz commented 7 years ago

I pulled, created the tags based on your changelog, but I don't see any update in my Grav instance. I created https://github.com/getgrav/grav/issues/978 so we will learn how to do it next time. Thanks!