Bugfix + Multi-Language-Support + IP Blocking

escopecz / grav-ganalytics

Google Analytics plugin for Grav CMS

MIT License

20 stars 9 forks source link

Bugfix + Multi-Language-Support + IP Blocking #8

Closed cworreschk closed 7 years ago

cworreschk commented 7 years ago

Hi John, it's me again :sunglasses:

In this pull request I have these issues:

Date format bugfix: In the Changelog was not the american date format (sorry)
Multi-language support: Initial with english and german
IP Blocking The possibility to not embed the GA code for specific IP addresses

Thank you very much :+1:

escopecz commented 7 years ago

It looks great at the first glance. Do you already use it in production or do you have some friend who could test it? I'm short on time, but I don't mind hit the merge button. I just don't want to break all websites using this plugin :)

escopecz commented 7 years ago

You know what? I added you as a collaborator to this repo so you can merge and tag new releases without my involvement. Feel free to do so if your changes are well-tested. And welcome to the team! I mean the team is you and me, but anyway, it's a team now ;)

cworreschk commented 7 years ago

Thank you very much for the invitation :smile: It's cool to work with you on this plugin.

I capsuled the existing code only in two functions, added the IP Block and the multi-language support in the blueprint-file.

Everything was tested by me yesterday, but I'll check it again and press the merge button afterwards :+1: