search

escoz / QuickDialog

QuickDialog - Quick and easy dialog screens for iOS
http://escoz.com/open-source/quickdialog
Other
3.07k stars 637 forks source link

crash under arm64 because of uncast objc_msgSend #613

Closed aksonov closed 10 years ago

aksonov commented 10 years ago

All objc_msgSend should be casted to avoid crash.

https://developer.apple.com/library/ios/documentation/General/Conceptual/CocoaTouch64BitGuide/ConvertingYourAppto64-Bit/ConvertingYourAppto64-Bit.html

escoz commented 10 years ago

What exactly is crashing?

aksonov commented 10 years ago

All calls to objc_msgSend gives EXC_BAD_ACCESS for arm64. Fix is quite easy - add cast, like

        ((void(*)(id, SEL, id))objc_msgSend)(controller,selector, self);

instead of objc_msgSend(controller,selector, self);

within QElement.m and other files

On Nov 19, 2013, at 18:13, Eduardo Scoz notifications@github.com wrote:

What exactly is crashing?

— Reply to this email directly or view it on GitHub.

mekanics commented 10 years ago

👍

escoz commented 10 years ago

Already done.

escoz commented 10 years ago

Meant to say this is on the 2.0 branch, which I'm working on. Thanks!