search

esdalmaijer / PyGaze

an open-source, cross-platform toolbox for minimal-effort programming of eye tracking experiments
www.pygaze.org
GNU General Public License v3.0
671 stars 211 forks source link

Further fixes and improvements to OpenSesame plug-ins and EyeLink functionality #12

Closed smathot closed 10 years ago

smathot commented 10 years ago

Again, a bunch of fixes and improvements that I ran into while implementing an experiment using the OpenSesame plug-ins. It's starting to shape up nicely.

One thing that I ran into again, is that the way that the config options are stored, in the defaults and (optionally) constants modules, carries some disadvantages that are pretty hard to work around. This is related to #5, but I'll close that one and open a different issue to outline the issue in a bit more detail.

esdalmaijer commented 10 years ago

Looks good. Concerning the constants: We could hard code the default values into the actual class definitions, so they do not have to be imported. Thing is, though, that some of the default values need to be available to multiple classes, so in my opinion defining them in one place is the most elegant way to do it. I suppose, though, that it needn't have to be a module, but could be a dict to which all modules have access as well, to allow for more dynamic behaviour.