search

esdalmaijer / PyGaze

an open-source, cross-platform toolbox for minimal-effort programming of eye tracking experiments
www.pygaze.org
GNU General Public License v3.0
671 stars 211 forks source link

More standards-compliant code formats? #125

Open jooh opened 5 years ago

jooh commented 5 years ago

I just started working on the code, and it's a little tricky to get used to some of the non-standard conventions, especially the super-deep indentation. Would it be worth running the whole repo through black to get something more PEP-8 compliant?

Similarly, the windows carriage returns are kind of annoying (top tip - set git config --local core.whitespace cr-at-eol to stop them showing up in git diff). Not sure if black will convert file endings anyway, but if not, a pass through dos2unix wouldn't hurt either...

esdalmaijer commented 5 years ago

Yeah, we should probably get on 4-space indentation, and a few more PEP8 compliances.

Thanks for the carriage return tips! Most of this stuff is written on a mixture of operating systems, and I don't always pay attention to these things.

jooh commented 5 years ago

If you're up for it, I can just run the repo through black and submit a PR. That should get you fairly strict PEP8.