esdalmaijer / PyGaze

an open-source, cross-platform toolbox for minimal-effort programming of eye tracking experiments
www.pygaze.org
GNU General Public License v3.0
670 stars 211 forks source link

openGaze division by zero #136

Open hcuve opened 4 years ago

hcuve commented 4 years ago

Hi @esdalmaijer,

I came across this at least twice while trying out a gaze point tracker, but forgot to save the error.

It seems like in the calibration there is some division by zero happening somewhere which triggers a float division by zero error.

Wondering if you have any ideas of the culprit?

Thanks, Helio

esdalmaijer commented 4 years ago

Hi Helio!

Could it have been here? https://github.com/esdalmaijer/PyGaze/blob/master/pygaze/_eyetracker/libopengaze.py#L474

That would mean no valid data points were collected during calibration/validation. Could this have been the case?

Cheers, Edwin

hcuve commented 4 years ago

Hi Edwin,

thanks, I think this is it. I will have a look tomorrow. On another note, wondering if pygaze supports streaming the GSR and self report dial data from the gazepoint biometrics kit. I talked to one of their developers and they said that this could be accessed through their API the same way you access the eye tracking data. I am looking to spend some time this week working on this, but just wanted to have your opinion, do you think it would require building a separate wrapper altogether, or it could be easily customized on your implementation of OpenGaze?

Cheers, Helio

Cheers

esdalmaijer commented 4 years ago

Hi Helio,

Good question! I don't currently have anything that hooks into that biometrics kit, but one could implement it within the OpenGazeTracker class in opengaze: https://github.com/esdalmaijer/PyGaze/blob/master/pygaze/_eyetracker/opengaze.py#L29

You'd have to update a couple of things:

Cheers, Edwin

hcuve commented 4 years ago

hi @esdalmaijer thanks loads for this, I will work on it once I am back to the office in a couple of days. Happy holidays!

Cheers, Helio