search

esdalmaijer / PyGaze

an open-source, cross-platform toolbox for minimal-effort programming of eye tracking experiments
www.pygaze.org
GNU General Public License v3.0
670 stars 211 forks source link

pylink 2.1 __version__ bugfix #159

Closed behinger closed 2 years ago

behinger commented 2 years ago

I recently got a new eyelink1000+ that was delivered with pylink 2.1.

In this pylink version, pylink.__version__ is a module (not a string anymore) containing pylink.__version__.__version__ with the version number as str. This simple fix solved an issue we had so far - I will perform some further testing tomorrow when I have access to the eye tracker again.

Cheers, Bene

PS: The fix is now from memory, I hope I didn't introduce a syntax error, but the gist of what it does should be quite obvious

esdalmaijer commented 2 years ago

Sadly, I'm currently in between EyeLinks! @smathot , you've looked at the same issue; does @behinger 's solution work?

smathot commented 2 years ago

It probably works but there are more substantial differences in the new PyLink SDK which break the fixation-triggered drift correction. I have a likely fix on this branch, but I still need to check whether the fix for the new SDK doesn't break things for the old SDK.

In other words, don't merge this other EyeLink-related PRs for now!

esdalmaijer commented 2 years ago

Thanks! I'll hold off then :)