search

esdalmaijer / PyGaze

an open-source, cross-platform toolbox for minimal-effort programming of eye tracking experiments
www.pygaze.org
GNU General Public License v3.0
671 stars 211 forks source link

Cleanup #40

Closed TheKevJames closed 8 years ago

TheKevJames commented 8 years ago

ongoing, do not merge

smathot commented 8 years ago

Hi,

If you're planning to contribute (at some point) to PyGaze, then of course you're more than welcome. But I would first contact @esdalmaijer and/ or me, to see how we can best handle any large changes. In particular, we're probably not going to merge a massive pep8-ing of the entire source code. Not because pep8 is bad, or the current source is perfect (far from it), but because code cleaning should be done safely, one step at a time, and preferably by someone who knows the code.

Do you see what I mean? We would love contributions of someone who knows what he's doing, but I think you may be drifting off a bit from where we want to go--which would be a shame.

Cheers! Sebastiaan

TheKevJames commented 8 years ago

Hey!

Yeah, sorry about this PR (and the other), I hadn't realized Github defaults to the upstream repo on creating PRs in forks.

The cleanup branch you see is mostly me looking through the codebase, refactoring as I go only for personal amusement/benefit/OCD/what have you. I may be submitting a PR in the future, but this certainly will neither be that PR nor a base for that PR.

Cheers, Kevin