search

esdalmaijer / PyGaze

an open-source, cross-platform toolbox for minimal-effort programming of eye tracking experiments
www.pygaze.org
GNU General Public License v3.0
671 stars 211 forks source link

wait_for_fixation_start() for Tobii tracker doesn't return the right time #45

Closed scattenlaeufer closed 7 years ago

scattenlaeufer commented 8 years ago

If I understand the code correctly, wait_for_fixation_start() for Tobii tracker doesn't return the time the fixation started, but the time the fixation was detected. Those times have a difference of at least self.fixtimetresh.

Since I am not sure whether this is a wanted behaviour, I didn't just fix it and create a pull request, but reported this as an issue to check whether it is really an issue.

esdalmaijer commented 7 years ago

Sorry, I must have forgot about this! Thanks for the pull request, it looks fine. And it makes sense to do it like this. The initial behaviour was intended to return the time of detection, but you're right: that might not necessarily be what you'd expect.

esdalmaijer commented 7 years ago

TODO: standardise this behaviour across all modules. EyeLink, EyeTribe, and SMI.