esdalmaijer / PyGaze

an open-source, cross-platform toolbox for minimal-effort programming of eye tracking experiments
www.pygaze.org
GNU General Public License v3.0
671 stars 211 forks source link

libinput.py needs updating for newer PsychoPy versions #59

Closed peircej closed 7 years ago

peircej commented 8 years ago

An error message about weakref has come up on the psychopy users list that would be best fixed in PyGaze libinput.py

https://groups.google.com/forum/#!topic/psychopy-users/SllmUo3egNs

PsychoPy's storage of open windows switched to using weak references a while ago to avoid circular references that were preventing proper garbage collection. A simple fix is suggested (but untested) in the link above.

peircej commented 8 years ago

Oh, this is probably a duplicate of #48 I think the fix suggested above will fix that too

esdalmaijer commented 8 years ago

Hi Jon,

Thanks for the info! We ran into the issue earlier, and fixed it by referring directly to the active window. See the PsychoPyMouse class, line 59.

The code you cited in the linked Google Group page is from an older version of PyGaze. (That's my bad for not advertising the newer version enough!)

Cheers, Edwin