Closed dirk-qualisys closed 5 years ago
As we all know, there are old documents around. Should we keep the pre-ATP8 classifications while adding the new ones, or should we delete them because they are not valid anymore? That in fact is a general decision - more cases like this will surely come up in future.
Just found that Flam. Aer. 1 and 2 (which were deleted in ATP4) are not part of the Classification enum anymore, so it might be ok to drop the old gas classifications as well.
Double-checked with the EuPhraC group: Old classifications should be dropped, then SDScom is consistent with EuPhraC.
HazardClassCategoryEnum covers the old classifications like "Compr. Gas", but not the latest ones like "Press. Gas (Comp.)". As this type is an enum, it is technically not necessary to adapt it to the new classification strings, but this type currently represents CLP classification wordings 1:1 and I think we should maintain this.