search

esdscom / sdscom-xml

Schema definition and other documents of eSDScom (formerly SDScom and ESCom), the standard for electronic exchange of Safety Data Sheets in a structured, processible way across Europe and other regions. Please read the wiki for more info. All work is licensed under CC BY-ND 4.0 (https://creativecommons.org/licenses/by-nd/4.0/legalcode)
https://www.esdscom.eu
27 stars 6 forks source link

Phrase-related types should be consistent with Phrase type #190

Closed dirk-qualisys closed 6 years ago

dirk-qualisys commented 6 years ago

While Phrase has been enhanced with a NewLine element, related types such as SupplementalHazardInformation and SpecialSupplementalLabelInfo should be either derived from Phrase or replaced by Phrase for better consistency.

dirk-qualisys commented 6 years ago

Affects HazardPictogram, SignalWord, HazardStatement, PrecautionaryStatement, SupplementalHazardInformation, SpecialSupplementalLabelInfo. In all these cases, the PhraseCode is restricted to an enum instead of being a free-text string.

As I did not find a way to modify the PhraseCode definition while taking all other definitons from Phrase, I will leave these types defined separately. SupplementalHazardInformation and SpecialSupplementalLabelInfo had an optional PhraseCode which makes no sense. But since all of these types basically represent lists, adding the NewLine element makes not much sense either, so this is not added. For plain consistency reasons I increased the length of FullText to string1024 (although we don't need this currently).