esdscom / sdscom-xml

Schema definition and other documents of eSDScom (formerly SDScom and ESCom), the standard for electronic exchange of Safety Data Sheets in a structured, processible way across Europe and other regions. Please read the wiki for more info. All work is licensed under CC BY-ND 4.0 (https://creativecommons.org/licenses/by-nd/4.0/legalcode)
https://www.esdscom.eu
27 stars 6 forks source link

Drop Excel schema description (e.g. IsToxicologicalValues vs IncludeToxicologicalValues) #69

Closed dlichtenberger-chemdox closed 6 years ago

dlichtenberger-chemdox commented 8 years ago

In the SDSCom/EDAS Excel overview file (SDSComXmlStandard_EDASxChem-Bau-4.2.0.xls), the following elements are misnamed:

IsPhysicalValues IsToxicologicalValues IsEcoToxicologicalValues

should be:

IncludePhysicalValues IncludeToxicologicalValues IncludeEcoToxicologicalValues

This also applies to the EDASxCHEM stylesheet.

Henrich-BGRCI commented 8 years ago

Thank you for the hint. This not a EDASx-only issue, because for the subset definition the excel table of SDScomXML version 4.2.0 was used. Here, an update of the table to the current version is needed first before using for subset definition.

dirk-qualisys commented 8 years ago

The reason for labeling was that the Excel file is no longer maintained for SDScom after moving to GitHub, if I remember correctly, but only to keep track of substandard definition. Thus I thought/think that this is part of the substandard (project) tasks.

Question is if and how the substandard definition is updated in future. I am afraid we should have discussed this in Berlin. Do we need the substandard definition in future or are EDASxBau/Chem dropped after this month?

Suter-IK commented 8 years ago

We are almost at the point, where we have a full sdscom export available. I kept EDASXChem in the header of my xml only to cover the needs of BGRCI. On the other hand, we should think at all of those, who didn't yet implement any XML export. It might be easier for a new Software vendor to start with a reduced set of fields.

Henrich-BGRCI commented 8 years ago

If the excel table is not longer maintained, the description given in the table should be transferred completly to the xsd. E.g., for the fields mentioned above I cannot find in the xsd any information about the default values as it given in the table.

Henrich-BGRCI commented 8 years ago

Here is an update of the EDASxChem (uncomplete SDScomXML) stylesheet: EDASxChem_style_v4.txt (just rename .txt in .xslt)

QuenzelGISBAU commented 8 years ago

I absolutely think the EDASxBau/Chem formats should not be dropped especially not this fast. Therefore I agree with Mr. Suter. I Think at least for the next few years it is even essential to have EDASxBau/Chem just to have a well definiend entry point into the whole complex of themes.

Regarding the whole Excel Business. Those have to be maintained. But I think this is something the SDBtransfer project partners have to talk about and should not be discussed here.

dirk-qualisys commented 8 years ago

To summarize:

We can collect further input here and should discuss this in the Berlin workshop if no solution is agreed here before.

dirk-qualisys commented 7 years ago

Consensus is to transfer the information from the Excel file into the schema defition and mark the field for SDScomBau and SDScomChem, e.g. in annotations like this:

  <xs:annotation>
      <xs:appinfo>SDScomBau</xs:appinfo>
      <xs:appinfo>SDScomChem</xs:appinfo>
      <xs:documentation>Explanation of the field...</xs:documentation>
  </xs:annotation>
Suter-IK commented 7 years ago

What is the intention to keep the substandard definitions in future?

dirk-qualisys commented 7 years ago

These may help new implementors to understand which fields deliver the best use, or could be applied in certain applications (GISBAU), if SDScom is implemented partially. And I am not aware of any full implementation.

From an administrative side and for the sake of Germany's SDBtrasfer project, results should be preserved for a couple of years. Once transferred, the new annotations do not need maintenance (while the Excel files would). So I agree this is probably the best way to proceed, at least if the substandards should be maintained.

Henrich-BGRCI commented 7 years ago

According to the schema given above, I will transfer from the Excel table into the XSD the documentation, which is given in the table but missing in the xsd, as well as the subset Definition for Bau and Chem. Afterwards, the local copy of the xsd can be merged with the current version.