search

eseifert / vectorgraphics2d

Graphics2D implementations to export various vector file formats
Eclipse Public License 2.0
108 stars 28 forks source link

Added SVG support for Path2D.WIND_EVEN_ODD #67

Closed davideby closed 6 years ago

davideby commented 6 years ago

This fixes a bug where setting e.g. a java.awt.LineBorder on a JPanel results in a solid-fill rectangle obscuring the contents.

Unfortunately I don't know the corresponding fix for PDF and EPS.

A little background: We're converting SVG export for our project (IGV) over from Batik as it's not ready for Java 9+ and is too heavyweight anyway. We considered writing our own exporter but yours is already in good shape. We found a couple of bugs in testing. This is the first and was pretty easy; we'll see how the next one goes.

Here's the relevant part of the spec.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.7%) to 47.548% when pulling 485723d43975cec8bd9c0b879edf49d091f28370 on igvteam:master into b2ba6a6a4f03744190c8f8131679c33f61894d25 on eseifert:master.

seifertm commented 6 years ago

Thank you for the enhancement! However, I will only be able to look at things tomorrow, sorry for the delay.

davideby commented 6 years ago

No problem! I was just about to try to figure out the EPS & PDF equivalents as well.

There's a bigger PR coming soon. Maybe I should file a GitHub Issue on that first in case we need to discuss it beforehand.

davideby commented 6 years ago

Added equivalents for EPS & PDF.