search

esek / ekorre

🐿 E-hemsidans backend i node skriven med Typescript, GraphQL via Apollo och Prisma
https://api.esek.se
GNU Affero General Public License v3.0
6 stars 2 forks source link

[FEATURE] Nödkontakter - [merged] #119

Closed esek-macapar closed 2 years ago

esek-macapar commented 2 years ago

In GitLab by @afroborg on Nov 29, 2021, 20:00

Merges feature/emergency-contacts -> master

esek-macapar commented 2 years ago

In GitLab by @afroborg on Nov 29, 2021, 20:00

requested review from @ginger51011

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Nov 29, 2021, 21:13

Commented on src/api/emergencycontact.api.ts line 27

Intisar

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Nov 29, 2021, 21:25

OcksÄ: CHANGELOG (sÄ kan du passa pÄ att fixa den fuckade versionen 0.2.4)

esek-macapar commented 2 years ago

In GitLab by @afroborg on Nov 30, 2021, 14:34

Commented on src/api/emergencycontact.api.ts line 27

lÀttast att bara skita i validering dÄ?

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Nov 30, 2021, 14:41

Commented on src/api/emergencycontact.api.ts line 27

AssÄ ja typ

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:26

Commented on src/api/emergencycontact.api.ts line 27

changed this line in version 2 of the diff

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:26

added 27 commits

Compare with previous version

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:28

added 1 commit

Compare with previous version

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:32

added 1 commit

Compare with previous version

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:36

Commented on src/api/emergencycontact.api.ts line 26

Detta har jag inte riktigt fÄtt att funka ordentligt pÄ SQLite, jag undrar om ett try-catch-block inte fÄngar detta egentligen? Tror knex kastar error om det inte gÄr, sÄ att kolla res hjÀlper typ inte

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:36

Commented on src/api/emergencycontact.api.ts line 26

(jag vet att detta har varit var standardlösning men i mina tester av election har just detta krÄnglat)

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:37

Commented on src/sql/emergencycontact.sql line 6

tab?

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:37

Commented on src/sql/init.sql line 192

Same

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:39

Commented on test/unit/emergencycontact.api.test.ts line 86

Mb, men fail fungerar inte hÀr. Tror du kan ha nÄgot som typ expect(contact).not.toBeUndefined() istÀllet för if-satsen. Jag vet att jag anvÀnt fail() men det Àr p.g.a. sketchy StackOverflow-svar. throw new Error() funkar ocksÄ

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:40

Commented on test/unit/emergencycontact.api.test.ts line 88

Jag hade lagt till en expect till som kontrollerar att den inte finns lÀngre efter anropet

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:41

Glöm ej att uppdatera package.json/package-lock.json-versionen med CHANGELOG!

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:45

Commented on src/sql/emergencycontact.sql line 6

nog bara i previewn, har inte det lokalt? :O

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:46

Commented on src/sql/emergencycontact.sql line 6

:O Gitlab is shit, noone suprised

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:47

Commented on src/api/emergencycontact.api.ts line 26

changed this line in version 5 of the diff

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:47

Commented on test/unit/emergencycontact.api.test.ts line 86

changed this line in version 5 of the diff

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:47

added 1 commit

Compare with previous version

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:48

Commented on src/api/emergencycontact.api.ts line 26

funkar i try catch men blir ju ganska fult, vi borde försöka hitta en bÀttre fullstÀndig lösning framöver

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:48

Commented on test/unit/emergencycontact.api.test.ts line 86

expect fÄr inte typescript att fatta att contact inte kan vara undefined sÄ fick bli en throw Error

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 13:49

added 1 commit

Compare with previous version

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:56

Commented on src/api/emergencycontact.api.ts line 26

Jo det Àr fult, men Àr vÀl typ relativt lÀttlÀsligt enligt mig. Hindrar ocksÄ att vi kastar fula SQL-errors till anvÀndare...

esek-macapar commented 2 years ago

In GitLab by @ginger51011 on Dec 7, 2021, 13:56

approved this merge request

esek-macapar commented 2 years ago

In GitLab by @afroborg on Dec 7, 2021, 14:25

mentioned in commit 50ddec55efec327c1c65e28c7e37a65e408683e5