search

esell / deb-simple

A lightweight, bare-bones apt repository server
MIT License
238 stars 17 forks source link

Static Analysis / Restructure #27

Closed dig412 closed 5 years ago

dig412 commented 5 years ago

Ok this is the last PR for now (I should get on and actually use the software...)

I've run a few static analysis tools (go fmt, go vet, gosimple, unused, golint, staticcheck) across the codebase, and fixed their recommendations.

I thought that main.go was getting a little large, so I've split it up into main, http, packages and signing. This is purely a style thing - if you'd prefer to keep it as one file I'm happy to drop the last commit in this PR and just submit the static / fmt changes.

(Side note - trying to rebase and resolve conflicts in commits that change indentation or move code between files is awful)

esell commented 5 years ago

@dig412, would you be able to rebase/sync this up with the latest changes in the main repo? there was a fix for one of the tests that i pushed the other day that is missing in these files causing the tests to fail: https://github.com/esell/deb-simple/commit/c47e8e6aa20a5a9ec752dfa66dcc2148c2da8982

dig412 commented 5 years ago

@esell Done! The actual tests passed on Jenkins, it's complaining about coveralls config.

esell commented 5 years ago

this is awesome, thanks for putting so much work into improving this.