esell / deb-simple

A lightweight, bare-bones apt repository server
MIT License
238 stars 17 forks source link

Make fsnotify configurable #32

Closed dig412 closed 5 years ago

dig412 commented 5 years ago

We've run into an issue using deb-simple where new packages can't be installed until a couple of minutes after uploading them. We have quite a few version of ~50Mb packages, so it takes a little while to hash them all to produce the Packages file.

One potential fix for this would be to move back to the pre-fsnotify behaviour and rebuild the Packages file as part of the package upload handler. This would mean our CI build wouldn't count as complete until the package was ready to install, which makes sense.

I can understand that being able to drop files into the packages directory is useful behaviour for some users, so I don't want to remove it.

@esell what do you think about making the behaviour here configurable? A setting to control if either the directory should be watched, or the Packages file should be rebuilt as a blocking part of the upload.

esell commented 5 years ago

hi @dig412, i think that would be awesome! as long as it is a feature that can be turned on/off i don't see any reason not to :). as you can likely tell based on how long it has taken me to respond, the amount of time i can put towards deb-simple is a bit limited, but i'll see what can be done.