search

esell / deb-simple

A lightweight, bare-bones apt repository server
MIT License
238 stars 17 forks source link

Illegal option -s #34

Closed svschwartz closed 4 years ago

svschwartz commented 5 years ago

I've tried to build debian package in docker container golang:1.12-buster and hit an error

root@3da6c33c12a8:/go/src/github.com/esell/deb-simple# make build-deb
which -s dpkg-deb || { echo "dpkg-deb does not exist, exiting..."; exit 1; }
Illegal option -s
Usage: /usr/bin/which [-a] args
dpkg-deb does not exist, exiting...
make: *** [Makefile:26: build-deb] Error 1

here is my patch to fix it

index 3976ed9..548c147 100644
--- a/Makefile
+++ b/Makefile
@@ -23,8 +23,7 @@ build-linux:
 build-osx:
    GOOS=darwin go build -o release/$(BINARY)-$(VERSION)-osx
 build-deb:
-   which -s dpkg-deb || { echo "dpkg-deb does not exist, exiting..."; exit 1; }
-   mkdir release/$(BINARY)-$(VERSION)
+   dpkg-deb --version >/dev/null || { echo "dpkg-deb does not exist, exiting..."; exit 1; }
    mkdir -p release/$(BINARY)-$(VERSION)/usr/local/bin
    mkdir -p release/$(BINARY)-$(VERSION)/etc/deb-simple
    cp -r DEBIAN release/$(BINARY)-$(VERSION)/