esenliyim / sp-tray

Gnome extension to display spotify metadata
GNU General Public License v3.0
55 stars 22 forks source link

Extension error since last update #12

Closed mcmxcdev closed 2 years ago

mcmxcdev commented 2 years ago

I just wanted to update the extension through the GNOME extension website, but it resulted in an error. The update yesterday worked without a problem, but the one today broke. Attempting to reinstall also results in an error.

I am running Ubuntu 21.10 with GNOME 40.4.0.

esenliyim commented 2 years ago

It's working just fine on my Ubuntu 21.10-Gnome 40 test VM, so you're gonna have to help me help you here. What's the error exactly? May sound obvious, but have you tried logging out and back into your gnome session? It helps sometimes.

hiveliberty commented 2 years ago

Same issue for me on Debian 11 (Gnome 3.38)

From logs:

Nov 18 16:39:25 someother gjs[17467]: JS ERROR: TypeError: SignalHandler[handler] is undefined#012buildPrefsWidget/<@/home/hive/.local/share/gnome-shell/extensions/sp-tray@sp-tray.esenliyim.github.com/prefs.js:1
23:13#012buildPrefsWidget@/home/hive/.local/share/gnome-shell/extensions/sp-tray@sp-tray.esenliyim.github.com/prefs.js:122:17#012_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:207:40#012Ope
nExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28#012asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:22#012run@resource:///org/gnome/Shell/Ext
ensions/js/dbusService.js:177:20#012main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13#012run@resource:///org/gnome/gjs/modules/script/package.js:222:19#012start@resource:///org/gnome/gjs/modules/scrip
t/package.js:206:8#012@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

and

Nov 19 15:51:39 someother gnome-shell[5443]: JS ERROR: Extension sp-tray@sp-tray.esenliyim.github.com: Error: A different version was loaded previously. You need to log out for changes to take effect.#012loadExt
ension@resource:///org/gnome/shell/ui/extensionSystem.js:342:52#012callback@resource:///org/gnome/shell/ui/extensionDownloader.js:222:39#012gotExtensionZipFile/<@resource:///org/gnome/shell/ui/extensionDownloade
r.js:106:13
esenliyim commented 2 years ago

Yeah I think I know what's happening. I think I'm not handling the disabling of the extension properly, which can cause problems when trying to update it without logging out and back in. I've had it happen to me with some other extensions before.

I'll look into it, but in the meantime, please check and see if uninstalling the extension, restarting gnome-shell and then reinstalling it does the trick.

edit: also could you tell me which version of the extension you're on? There are 2 of them active.

hiveliberty commented 2 years ago

I checked both yesterday. Sorry for disinformation. I installed extension through GNOME Shell integration in browser - latest, i think hm.. logout and login again fix this issue

mcmxcdev commented 2 years ago

Reinstalling extension didn't work for me, but relogging into Ubuntu fixed the issue for me now!

Version seems to be 10 according to "Extensions" application on Ubuntu.