search

esenliyim / sp-tray

Gnome extension to display spotify metadata
GNU General Public License v3.0
58 stars 23 forks source link

feat: french translation #27

Closed whiterqbbit closed 2 years ago

whiterqbbit commented 2 years ago

Hey, I translated this in french. I didn't make a .mo file thought.

esenliyim commented 2 years ago

Merci beaucoup. Don't worry about the .mo, I can take care of it.

I'll include your translation with the next version, which I'll try to upload this weekend, if I can find the time. Kinda busy with more important things these days, unfortunately.

e7d commented 2 years ago

Hot damn!

I had one on my belt for a few weeks now. I got busy and kind of forgot about it until today, then I see someone else beat me to it. :smile: No worries though.

I'm just concerned about the way @whiterqbbit translated it, as the produced file does not seem to respect the directory tree of other translation files. Wouldn't it be an issue?

esenliyim commented 2 years ago

Oh damn you're right, the structure is indeed wrong. I should have reviewed it more carefully. Good catch.

@whiterqbbit I was gonna do the compiling anyway, in the meantime I took care of placing the file where it should have been in the first place. I should have been more careful, but I'd appreciate it if you were also more careful next time.

whiterqbbit commented 2 years ago

My bad! I'm really sorry and thanks Michael for pointing it out :)

Le jeu. 19 mai 2022 à 11:40, esenliyim @.***> a écrit :

Oh damn you're right, the structure is indeed wrong. I should have reviewed it more carefully. Good catch.

@whiterqbbit https://github.com/whiterqbbit I was gonna do the compiling anyway, in the meantime I took care of placing the file where it should have been in the first place. I should have been more careful, but I'd appreciate it if you were also more careful next time.

— Reply to this email directly, view it on GitHub https://github.com/esenliyim/sp-tray/pull/27#issuecomment-1131474094, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUIJWUJNUO5YKDGBWQSP5DVKYD75ANCNFSM5WFQZQNA . You are receiving this because you were mentioned.Message ID: @.***>

esenliyim commented 2 years ago

Since then some new strings have been added. I learned French some years ago, haven't really spoken it for like 10 years or so, and right now I'm only good for detecting when Google Translate's results are way off, but I can't really correct them myself.

I'd much appreciate it if one of you fine people could give the French localization a look.

whiterqbbit commented 2 years ago

All good !

esenliyim commented 2 years ago

With one of the last commits I've also introduced 5-6 new strings, which I haven't translated. I mean I tried, but Google Translate's results felt wrong so I left them untouched. That's actually what prompted this request in the first place.

whiterqbbit commented 2 years ago

I see! Added them.