esenliyim / sp-tray

Gnome extension to display spotify metadata
GNU General Public License v3.0
58 stars 23 forks source link

Panel button somehow claims more space than it needs (in static display mode) #36

Closed HeroBrine1st closed 1 year ago

HeroBrine1st commented 2 years ago

Hello.

I hovered cursor and took this screenshot: image You can see the panel button is bigger than text itself and it exceeds available space, so other panels are shorter than they should be (see four numbers on other screenshorts - they usually have percent and temperature signs). Settings used: image These settings are that small simply for screenshots, of course. I should say that it does not try to claim all available space (I mean, not always at least) - for example, when I open non-maximized window, "close" and "minimize" buttons are hidden (they are from Unite extension btw), so it looks like this: image


Also, this problem does not appear in marquee mode: image image Even if I try to set absurdly high length limit, it does "smart limit" thing: image image (Btw, high limit disables the marquee, so you can set it to claim all available space as needed, but without the problem above)

System information:

esenliyim commented 2 years ago

I'm like 90% sure I know what's causing this. I'll get on it ASAP.

esenliyim commented 2 years ago

Yeah I was immediately able to recreate it myself. Pushed a fix to the dev branch just now (literally one single line of code), which I hope is the last time I'm fixing this stupid bug. I've fixed and reintroduced it a few times already. Looks fixed from where I'm standing but I'd appreciate it if you could take a quick look yourself.

HeroBrine1st commented 2 years ago

I ran ./install.sh on dev branch, but don't want to test today (I mean, I'll start my PC tomorrow and, if don't forget, will check it. It's night in my location, so I should be sleeping already xD) Did a dirty install tho - didn't delete old version, but I think and hope it's okay.

HeroBrine1st commented 2 years ago

Working great! Thank you! image

P.s. I'm not closing as it is a dev version fix