search

esenliyim / sp-tray

Gnome extension to display spotify metadata
GNU General Public License v3.0
58 stars 23 forks source link

Display album cover #37

Open pasikonik opened 1 year ago

pasikonik commented 1 year ago

This extension is great, but I'm missing one functionality. I'm talking about showing an album cover after click on tray or keyboard shortcut (better one).

Do you consider adding this feature? Media Controls has it, but for me simplicity is important, therefore I chose this extension. Screenshot from 2023-03-03 11-03-07

I can try to do a Pull Request if you accept the contributions here.

esenliyim commented 1 year ago

I've considered this in the past, but decided against it because I thought it goes beyond my goal of creating "a simple label" that's just there.

I'll give it more thought, though. You could fire a PR if you've already implemented it yourself, but otherwise don't bother because I could very well end up rejecting it and wasting your time.

esenliyim commented 1 year ago

A small update on this, I'm currently experimenting with an A-B repeat feature, which I've always found is criminally missing from most modern media players. It's gonna be an ugly and imprecise hack at best, but better than nothing I guess.

Anyway, what that means is, if I decide to add it to this extension, it might mean I might start taking it in another direction. Which would in turn mean making it a bit more feature-rich, rather than just a simple label.

Moon-0xff commented 3 months ago

Hello! I stumbled upon this issue and I figured it's best if I share that we implemented this a year ago for gnome-mpris-label.

The conversation thread is a lot of back-and-forth, but the final changes merged to the main branch are quite small, just check the diff (or the "files changed" tab on github) of the files players.js and extension.js.