search

eserte / perl-tk

the perl module Tk
https://metacpan.org/release/Tk
Other
44 stars 31 forks source link

Derived.pm: fix spelling in comment #45

Closed chrstphrchvz closed 3 years ago

chrstphrchvz commented 5 years ago

@eserte I'd like to pick your brain regarding the code just below this comment. What would be a good venue to do so?

Tcl::pTk borrows this code, however the hardcoded default colors cause an appearance issue at least on macOS aqua: https://rt.cpan.org/Ticket/Display.html?id=125049. I have not figured out how to resolve this issue, but I imagine I do not understand the purpose of this code very well. Would it be possible to have it leave the colors unset, letting the window manager use default colors? Do Perl/Tk programs depend on these defaults being set? (Edit: see #52)

eserte commented 3 years ago

I also have to dig deeper into this code and the purpose for it, but I vaguely remember that there were both benefits and downsides doing this bg/fg propagation.