search

eserte / perl-tk

the perl module Tk
https://metacpan.org/release/Tk
Other
44 stars 31 forks source link

jpeg: fix build with clang 16 #93

Closed stigtsp closed 12 months ago

stigtsp commented 1 year ago

The jpeg configure script fails to detect clang as a functioning C compiler because it uses a test with a main that returns an implicit int, which results in an error with clang 16.

From https://github.com/NixOS/nixpkgs/pull/253730

Cc: @reckenrode

chrstphrchvz commented 12 months ago

I agree that this change is needed. However, other changes are needed for the configure script to work properly and detect e.g. fopen() behavior and whether char is signed. I have opened #94 with those changes as well as the one here.

Note that the CI workflow currently only builds Perl/Tk against system libjpeg (the configure step output contains Using system's -ljpeg rather than Building jpeg/libjpeg.a) and so will not test the changes proposed to this configure script.

stigtsp commented 12 months ago

Ok will close this PR in favor of #94