search

esg-epfl-apc / astrojsvis

0 stars 0 forks source link

make a gh page with both vis cases and fits reader #7

Closed volodymyrss closed 7 months ago

francoismg commented 7 months ago

As said on light curve vis issue, will move the changes to the main graph in a new file so it will look more like the final result

volodymyrss commented 7 months ago

Pages enabled as so:

image

Please suggest change as needed. Maybe we should make it on main? Another dir?

edit: I changed to main, dir /docs

it's showing in https://esg-epfl-apc.github.io/astrojsvis/ now. Please add there, @francoismg and @dsavchenko !

francoismg commented 7 months ago

Pages enabled as so:

Please suggest change as needed. Maybe we should make it on main? Another dir?

edit: I changed to main, dir /docs

it's showing in https://esg-epfl-apc.github.io/astrojsvis/ now. Please add there, @francoismg and @dsavchenko !

Thanks, think main is fine but another branch would have prevented people who want to fork the actual project or something to have to download the gh pages with it I think

dsavchenko commented 7 months ago

Thanks, think main is fine but another branch would have prevented people who want to fork the actual project or something to have to download the gh pages with it I think

It's meant to be more a preview for us. No need to bother about forks, I think.

As a side-note, it would be useful to use this action https://github.com/marketplace/actions/deploy-pr-preview at some point

volodymyrss commented 7 months ago

Thanks, think main is fine but another branch would have prevented people who want to fork the actual project or something to have to download the gh pages with it I think

It's meant to be more a preview for us. No need to bother about forks, I think.

Yes.

As a side-note, it would be useful to use this action https://github.com/marketplace/actions/deploy-pr-preview at some point

Indeed, this would improve the flow. Actually, feel free to add it to your PR (and @francoismg please make a PR too), then we can see if we make it work (I will change the PR to gh-pages to check)

dsavchenko commented 7 months ago

I changed pages build to gh-pages branch.

To automatically add the PR preview, configuration required that I don't have permissions to do.

So I simulated manually what the preview action will do, just pushed to the gh-pages branch. Here is the link https://esg-epfl-apc.github.io/astrojsvis/manual-preview-pr/pr-5/lc_demo.html

@francoismg you can put a preview of the d3 viewer in the same way.

volodymyrss commented 7 months ago

I changed pages build to gh-pages branch.

To automatically add the PR preview, configuration required that I don't have permissions to do.

So I simulated manually what the preview action will do, just pushed to the gh-pages branch. Here is the link https://esg-epfl-apc.github.io/astrojsvis/manual-preview-pr/pr-5/lc_demo.html

@francoismg you can put a preview of the d3 viewer in the same way.

Could you add a button to set LC url so we can try different ones easily?

dsavchenko commented 7 months ago

You mean the link to it in main index.html?

francoismg commented 7 months ago

@francoismg you can put a preview of the d3 viewer in the same way.

Thanks, seems to be working.

I also added links to both demo in the main page