search

esg-epfl-apc / tools-astro

1 stars 3 forks source link

Github action for updating archives list #107

Closed francoismg closed 4 weeks ago

francoismg commented 7 months ago

As discussed in https://github.com/esg-epfl-apc/tools-astro/issues/64

francoismg commented 7 months ago

@volodymyrss @dsavchenko

volodymyrss commented 5 months ago

@francoismg do we have something to finish and conversations to resolve here? Could you please have a look?

francoismg commented 5 months ago

Actions need to be granted the right to create pull request in settings -> actions

volodymyrss commented 5 months ago

Actions need to be granted the right to create pull request in settings -> actions

Ok, done. Could you please check now?

francoismg commented 5 months ago

Actions need to be granted the right to create pull request in settings -> actions

Ok, done. Could you please check now?

seems all good https://github.com/esg-epfl-apc/tools-astro/pull/111

I should just make sure that it will only contains the commits with the list update otherwise it will always try to push the new action to main

volodymyrss commented 5 months ago

let's do it Thursday night once a week

volodymyrss commented 2 months ago

@dsavchenko could you please review?

francoismg commented 1 month ago

The version of the tool needs to be updated here (discussion above)

Tool version update is working on my local test setup, just need to rework fetch_archives script so the sample file only contains columns description and first row and then will test it against the real repo

volodymyrss commented 1 month ago

Thanks for the update, @francoismg , could you push your WIP here?

francoismg commented 1 month ago

Thanks for the update, @francoismg , could you push your WIP here?

WIP has been updated to work with pull request and is pushed, should work but had a pyvo exception last few runs so couldn't validate everything will try again in a moment

francoismg commented 1 month ago

Everything is working on my side but I can't test it directly here cause workflow dispatch is not available (not sure if permission issue or something else), we can try to merge and see if it's working if it's ok with you @volodymyrss