search

esgf2-us / intake-esgf

Programmatic access to the ESGF holdings
https://intake-esgf.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

drop zero length query fields #29

Closed jsta closed 5 months ago

jsta commented 5 months ago

This PR enables running the following query with a zero length field entry:

cat.search(
    experiment_id="historical",
    source_id="CanESM5",
    frequency="mon",
    variable_id=["gpp", "tas", "pr"],
    variant_label="",
)
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f311288) 86.71% compared to head (9956924) 86.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## ========================================== + Coverage 86.71% 86.73% +0.01% ========================================== Files 10 10 Lines 700 701 +1 ========================================== + Hits 607 608 +1 Misses 93 93 ``` | [Flag](https://app.codecov.io/gh/esgf2-us/intake-esgf/pull/29/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/esgf2-us/intake-esgf/pull/29/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | `86.73% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.