search

esgf2-us / intake-esgf

Programmatic access to the ESGF holdings
https://intake-esgf.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
10 stars 6 forks source link

Added new configuration option for `additional_df_cols`. #54

Closed huard closed 5 months ago

huard commented 5 months ago

Adds configurable extra columns.

Open question: should datetime_start and datetime_end be converted to datetime objects somewhere ?

nocollier commented 5 months ago

@mgrover1 Do you know any better? I tried looking for a way to rather make pandas use datetime64[s] as opposed to datetime[ns] but it doesn't seem possible.

nocollier commented 5 months ago

@huard We decided to just merge and address the datetime conversion later. We are wanting to release and want this in.

huard commented 5 months ago

Great ! One option for the dates would be to use cftime objects, but that's another dependency.