Closed jasonb5 closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8b6a989
) 100.00% compared to head (36b779c
) 100.00%. Report is 92 commits behind head on v1.0.10.:exclamation: Current head 36b779c differs from pull request most recent head 9762034. Consider uploading reports for the commit 9762034 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Combining PRs as it may be some time before a merge/release.
@jasonb5 v1.0.10 is in "great shape" so we have working CI again. (Just now fails one linter check but I think we can resolve)
Was this closed by mistake? It is trivial to change a base branch, IIRC a while ago you could not...
Looks like there is a limitation in Github. If you delete the branch and close the PR. you cannot change the branch to something else and reopen. This is annoying. The better practice is to (1) switch the branch of the PR first, (2) then delete the branch. So @jasonb5 we'll re-create the PR for you..
Description
This PR will be a general update for containers.
Todo before merge:
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist