esgf2-us / metagrid

ESGF Search UI
https://metagrid.readthedocs.io/en/latest/
MIT License
16 stars 4 forks source link

General container update #561

Closed jasonb5 closed 8 months ago

jasonb5 commented 11 months ago

Description

This PR will be a general update for containers.

Fixes # (issue)

Type of change

How Has This Been Tested?

Checklist

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8b6a989) 100.00% compared to head (36b779c) 100.00%. Report is 92 commits behind head on v1.0.10.

:exclamation: Current head 36b779c differs from pull request most recent head 9762034. Consider uploading reports for the commit 9762034 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1.0.10 #561 +/- ## =========================================== Coverage 100.00% 100.00% =========================================== Files 78 30 -48 Lines 2156 854 -1302 Branches 330 0 -330 =========================================== - Hits 2156 854 -1302 ``` | [Flag](https://app.codecov.io/gh/aims-group/metagrid/pull/561/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aims-group) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/aims-group/metagrid/pull/561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aims-group) | `100.00% <100.00%> (ø)` | | | [frontend](https://app.codecov.io/gh/aims-group/metagrid/pull/561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aims-group) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aims-group#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jasonb5 commented 11 months ago

Combining PRs as it may be some time before a merge/release.

sashakames commented 8 months ago

@jasonb5 v1.0.10 is in "great shape" so we have working CI again. (Just now fails one linter check but I think we can resolve)

sashakames commented 7 months ago

Was this closed by mistake? It is trivial to change a base branch, IIRC a while ago you could not...

sashakames commented 7 months ago

Looks like there is a limitation in Github. If you delete the branch and close the PR. you cannot change the branch to something else and reopen. This is annoying. The better practice is to (1) switch the branch of the PR first, (2) then delete the branch. So @jasonb5 we'll re-create the PR for you..