esgf2-us / metagrid

ESGF Search UI
https://metagrid.readthedocs.io/en/latest/
MIT License
16 stars 4 forks source link

V1.1.0 #592

Closed downiec closed 4 months ago

downiec commented 8 months ago

Description

This is the new update branch for Metagrid

Fixes #

How Has This Been Tested?

Checklist

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 97.64706% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.54%. Comparing base (2e90dd1) to head (a93ec06).

Files Patch % Lines
frontend/src/components/Globus/DatasetDownload.tsx 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #592 +/- ## ========================================== + Coverage 97.75% 98.54% +0.79% ========================================== Files 46 76 +30 Lines 1823 2745 +922 Branches 415 415 ========================================== + Hits 1782 2705 +923 + Misses 41 40 -1 ``` | [Flag](https://app.codecov.io/gh/esgf2-us/metagrid/pull/592/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/esgf2-us/metagrid/pull/592/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | `100.00% <100.00%> (?)` | | | [frontend](https://app.codecov.io/gh/esgf2-us/metagrid/pull/592/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | `97.82% <97.33%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sashakames commented 7 months ago

Plan to include the following:

sashakames commented 7 months ago

Screenshot 2024-02-12 at 10 55 41 AM

sashakames commented 7 months ago

I recall we passed this, what gives????

downiec commented 7 months ago

Not sure why it's failing now, will have to look into it.

jasonb5 commented 6 months ago

@downiec Can we get pre-commit to run on branches targeting vX.X.X branches? I realized that last formatting issue was from my branch.

downiec commented 6 months ago

@downiec Can we get pre-commit to run on branches targeting vX.X.X branches? I realized that last formatting issue was from my branch.

Yeah, I think we would need to adjust the pre-commit.yml file to do that

sashakames commented 6 months ago

I think we will call this branch feature complete. Once tests pass for the final PR, we can put this under review and plan to merge...

jasonb5 commented 5 months ago

@downiec @sashakames I found some issues with the containers, need to put in one last fix.

sashakames commented 5 months ago

Should we close this and rename to v1.1.2 ?