Closed downiec closed 4 months ago
Attention: Patch coverage is 97.64706%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 98.54%. Comparing base (
2e90dd1
) to head (a93ec06
).
Files | Patch % | Lines |
---|---|---|
frontend/src/components/Globus/DatasetDownload.tsx | 33.33% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I recall we passed this, what gives????
Not sure why it's failing now, will have to look into it.
@downiec Can we get pre-commit to run on branches targeting vX.X.X branches? I realized that last formatting issue was from my branch.
@downiec Can we get pre-commit to run on branches targeting vX.X.X branches? I realized that last formatting issue was from my branch.
Yeah, I think we would need to adjust the pre-commit.yml file to do that
I think we will call this branch feature complete. Once tests pass for the final PR, we can put this under review and plan to merge...
@downiec @sashakames I found some issues with the containers, need to put in one last fix.
Should we close this and rename to v1.1.2
?
Description
This is the new update branch for Metagrid
Fixes #
How Has This Been Tested?
Checklist