esgf2-us / metagrid

ESGF Search UI
https://metagrid.readthedocs.io/en/latest/
MIT License
17 stars 4 forks source link

V1.1.0 container update #608

Closed jasonb5 closed 6 months ago

jasonb5 commented 6 months ago

Description

This PR will be a general update for containers.

Fixes # (issue)

Type of change

How Has This Been Tested?

Checklist

jasonb5 commented 6 months ago

Here's a status of all commits made in https://github.com/esgf2-us/metagrid/pull/594.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c9d3888) 100.00% compared to head (8ae5825) 98.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1.1.0 #608 +/- ## =========================================== - Coverage 100.00% 98.54% -1.46% =========================================== Files 30 76 +46 Lines 910 2751 +1841 Branches 0 420 +420 =========================================== + Hits 910 2711 +1801 - Misses 0 40 +40 ``` | [Flag](https://app.codecov.io/gh/esgf2-us/metagrid/pull/608/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/esgf2-us/metagrid/pull/608/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | `100.00% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/esgf2-us/metagrid/pull/608/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | `97.82% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sashakames commented 6 months ago

Thank you @jasonb5 @downiec could review just to be sure, and I'll do a production regression test merge on our green-net server. Have you run this branch on Nimbus yet?

jasonb5 commented 6 months ago

I haven't yet, it's next up.

TODO

sashakames commented 6 months ago

This failed test might be an intermittent issue

downiec commented 6 months ago

This failed test might be an intermittent issue

Still trying to figure out why this fails on github but passes locally...