esgf2-us / metagrid

ESGF Search UI
https://metagrid.readthedocs.io/en/latest/
MIT License
17 stars 4 forks source link

Fixes local container #616

Closed jasonb5 closed 5 months ago

jasonb5 commented 5 months ago

Description

This PR updates the local container to utilize the production entrypoint. This solves three issues; the first is HTML not rendering in the news widget, the second is correctly rendering the index.html and runtime_env.js, and lastly fixing the runtime_env.js being written to the correct directory for local development.

Note that the index.html must continue to use $VAR rather than %VAR%. This enables runtime configuration, if %VAR% is used then the build process will substitute the values breaking runtime configuration.

Fixes # (issue)

613

Type of change

How Has This Been Tested?

Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.54%. Comparing base (caa6aec) to head (bd3af2b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v1.1.0 #616 +/- ## ======================================= Coverage 98.54% 98.54% ======================================= Files 76 76 Lines 2752 2752 Branches 416 416 ======================================= Hits 2712 2712 Misses 40 40 ``` | [Flag](https://app.codecov.io/gh/esgf2-us/metagrid/pull/616/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/esgf2-us/metagrid/pull/616/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | `100.00% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/esgf2-us/metagrid/pull/616/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us) | `97.82% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esgf2-us#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sashakames commented 5 months ago

Is this another "intermittent" error?

       944 |
      945 |     // GitHub icon renders
    > 946 |     const metagridSupportHeader = findByText(' MetaGrid Support');
          |                                   ^
      947 |     expect(metagridSupportHeader).toBeTruthy();
jasonb5 commented 5 months ago

There might be an issue specific to the Helm chart, looking into it now.

jasonb5 commented 5 months ago

Confirmed need to make another change to this PR.

jasonb5 commented 5 months ago

@sashakames @downiec Figured out the failing test, I forgot that the index.html needs to be manually rendered in the frontend testing workflow.