Closed jasonb5 closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.54%. Comparing base (
caa6aec
) to head (bd3af2b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is this another "intermittent" error?
944 |
945 | // GitHub icon renders
> 946 | const metagridSupportHeader = findByText(' MetaGrid Support');
| ^
947 | expect(metagridSupportHeader).toBeTruthy();
There might be an issue specific to the Helm chart, looking into it now.
Confirmed need to make another change to this PR.
@sashakames @downiec Figured out the failing test, I forgot that the index.html
needs to be manually rendered in the frontend testing workflow.
Description
This PR updates the local container to utilize the production entrypoint. This solves three issues; the first is HTML not rendering in the news widget, the second is correctly rendering the
index.html
andruntime_env.js
, and lastly fixing theruntime_env.js
being written to the correct directory for local development.Note that the
index.html
must continue to use$VAR
rather than%VAR%
. This enables runtime configuration, if%VAR%
is used then the build process will substitute the values breaking runtime configuration.Fixes # (issue)
613
Type of change
How Has This Been Tested?
Checklist