search

esh-b / RAML-to-Swagger-Converter

A java project to convert RAML 0.8 definition to Swagger 2.0 definition
BSD 3-Clause "New" or "Revised" License
17 stars 9 forks source link

Fixes for build, recursive resolver fix #1

Closed sslb closed 7 years ago

sslb commented 7 years ago

Hey,

Nice project, good job! I have resolved a couple of issues, implemented maven build and resolved an issue with one of the recursive functions resolving nested properties.

Also changed some code to be more 'java'. If you are happy to pull my changes then I'll destroy my fork and happy to contribute to your project. If not, that's OK, I'll maintain the fork separately.

Szabolcs

esh-b commented 7 years ago

Hey @sslb, thanks for the contribution. I will review the changes and merge your request.

esh-b commented 7 years ago

Hey @sslb, thanks for making the code "javaish" :). But, few queries.. 1) Can I know what are the test cases (raml files) that you used to validate your new code? Also, make sure you have updated the readme accordingly. 2) Also, I would suggest to add comments for lines where maps or some complex functions are used so that it's easier for the reader.