search

eshaan7 / Flask-Shell2HTTP

Execute shell commands via HTTP server (via flask's endpoints).
https://flask-shell2http.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
170 stars 28 forks source link

Fixes #42: ImportError for `safe_join` #41

Closed madhavajay closed 2 years ago

madhavajay commented 2 years ago

New Flask versions cause the following error:

ImportError: cannot import name 'safe_join' from 'flask.helpers' (/root/.local/lib/python3.9/site-packages/flask/helpers.py)

It looks to have been deprecated and shifted to werkzeug: https://github.com/pallets/flask/pull/4337

codecov[bot] commented 2 years ago

Codecov Report

Merging #41 (d614994) into master (4cfcfb5) will increase coverage by 0.16%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   86.34%   86.50%   +0.16%     
==========================================
  Files           6        6              
  Lines         249      252       +3     
  Branches       33       33              
==========================================
+ Hits          215      218       +3     
  Misses         21       21              
  Partials       13       13
Impacted Files Coverage Δ
flask_shell2http/classes.py 83.00% <100.00%> (+0.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cfcfb5...d614994. Read the comment docs.

madhavajay commented 2 years ago

Wow lots of extra considerations thanks @eshaan7! ❤️