search

eshaan7 / Flask-Shell2HTTP

Execute shell commands via HTTP server (via flask's endpoints).
https://flask-shell2http.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
171 stars 28 forks source link

Decode process output to "utf-8" instead of "ascii" #5

Closed vBLFTePebWNi6c closed 3 years ago

eshaan7 commented 3 years ago

Hi. Thank you for your contribution. Can you tell me the instance where you felt the need of utf-8 encoding ? Was the stdout breaking when encoded to ascii as is implemented ATM ?

vBLFTePebWNi6c commented 3 years ago

Hi. Thank you for your contribution. Can you tell me the instance where you felt the need of utf-8 encoding ? Was the stdout breaking when encoded to ascii as is implemented ATM ?

Hi. I make this PR because I got Job: 'afc1d565' --> failed. Reason: "'ascii' codec can't decode byte 0xd0 in position 264: ordinal not in range(128)". on jobs with cyrillic output.

eshaan7 commented 3 years ago

Thank you for your contribution, @vBLFTePebWNi6c. I have created the new release v1.5.2 with your PR merged.

EDIT: The latest version should also be available on PyPI.