search

eshaham / israeli-bank-scrapers

Provide scrapers for all major Israeli banks and credit card companies
MIT License
599 stars 162 forks source link

bad description on error when scrapping isracard #788

Open liranelisha opened 1 year ago

liranelisha commented 1 year ago

description

before scrapping there should be validation that all mandatory fields exists in the given JSON. this isn't seems to be the case for isracard

expected behavior

scrapping isracard without the card6Digits or any other field will generate a readable and actionable message.

actual behavior

when scrapping isracard card without the card6Digits field i'm getting errorType=GENERIC and errorMessage='Evaluation failed: SyntaxError: Unexpected end of JSON input\n at __puppeteer_evaluation_script__:16:26'

github-actions[bot] commented 3 days ago

Issue has been marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.