search

eshaham / israeli-bank-scrapers

Provide scrapers for all major Israeli banks and credit card companies
MIT License
587 stars 160 forks source link

fix: Visa Cal - add missing transactions and fix the amount sign in case of credit (refund) #808

Closed itamarco closed 9 months ago

itamarco commented 1 year ago

Fixes #807 This PR fix 2 issues with Visa Cal scraper:

  1. In case of credits (refund) the "amount" field is still in minus instead of plus.
  2. The scraper ignored the "immidiateDebits" field that may contains additional transactions

image

esakal commented 11 months ago

@itamarco thanks for the contribution. @eshaham can you check why the checks are on status waiting? I cannot merge the PR

esakal commented 9 months ago

@eshaham I managed to merge a PR #811 but this one is still stuck on the checks. Please merge. hopefully new PRs will work also for me

github-actions[bot] commented 8 months ago

:tada: This PR is included in version 4.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: