eshaham / israeli-bank-scrapers

Provide scrapers for all major Israeli banks and credit card companies
MIT License
567 stars 152 forks source link

Would you be willing to approve a PR for FamilyBiz integration? #840

Closed gur111 closed 4 months ago

gur111 commented 4 months ago

I'm interested in having FamilyBiz integration. FamilyBiz can use Open Banking to pull information from various services. Then, you can use their REST API to get the information from everything all at once which is both faster and AFAIK also legal and falls under fair use:

image
baruchiro commented 4 months ago

@eshaham @esakal Interesting idea, didn't check it yet.

baruchiro commented 4 months ago

Although I liked your idea, if they are truly not asking for passwords, and their REST is available for usage, it can solve the main problem of using passwords.

But if you've already configured FamilyBiz, why do you need to download the data from there?

gur111 commented 4 months ago

IMO the added value of connecting FamilyBiz is to allow user to use open banking with custom apps they want to make. It reduces the chance for something specific to break. The reason I think it’s not a replacement for the entire project is that while is uses open banking, all the data goes through a 3rd party (FamilyBiz) and possibly unappealing to many users.

Having it as an option though, doesn’t hurt and many users would prefer it over providing passwords and updating them every however long the password expiration policy is.

Not sure I understood your last question though. I want to download the data from FamilyBiz because some projects use your amazing library as backend and the end goal isn’t merely just inspecting the data. for example I did an IOT devise that sticks to your fridge and shows you spending summaries to raise awareness for your spendings. You can’t do that without accessing the raw data.

P.S. yes, no official REST API and like scraping reversing and investigating is required. Though we don’t need the binary of the app, mitmproxy does the job well enough. No cert pinning.

erikash commented 4 months ago

Hi @gur111 , Thanks for the interesting suggestion. After discussing this internally we decided to pass on the initiative due to the following reasons:

  1. Per the library name it doesn't scrape a banking site - FamilyBiz is a data aggregator
  2. It's not guaranteed to be accessible to non-paying FamilyBiz customers.
  3. This project is about making your own data accessibly without relying or sharing it with a third party such as FamilyBiz.

That said - this is an interesting initiative for a new open source project.

gur111 commented 4 months ago

Hi @gur111 , Thanks for the interesting suggestion. After discussing this internally we decided to pass on the initiative due to the following reasons:

  1. Per the library name it doesn't scrape a banking site - FamilyBiz is a data aggregator
  2. It's not guaranteed to be accessible to non-paying FamilyBiz customers.
  3. This project is about making your own data accessibly without relying or sharing it with a third party such as FamilyBiz.

That said - this is an interesting initiative for a new open source project.

Well. I can’t argue with the third one but the first two: well the One Zero integration isn’t scraping anything either and as I’m not a paying FamilyBiz customer, I can’t guarantee what paying customers are getting, I CAN guarantee what I’m getting as a free customer. anyways, I guess I’ll push my own fork then as from my perspective FamilyBiz is yet just another financial service I’m using and I don’t see a reason to do another repo from scratch. It wouldn’t be as convenient for people to learn a multiple libraries just to including a more broad support.

baruchiro commented 4 months ago

Good luck @gur111!

Please comment here with your fork when it will be ready 🙏