search

eshaham / israeli-bank-scrapers

Provide scrapers for all major Israeli banks and credit card companies
MIT License
567 stars 152 forks source link

[Max] Issue: bad password return GENERAL_ERROR instead CHANGE_PASSWORD #846

Closed gczobel closed 3 months ago

gczobel commented 3 months ago

The PASSWORD_EXPIRED_URL was changed and when the password is expired a wrong error is returned.

024-03-30T13:45:15.913Z moneyman:scrape [max] LOGGING_IN
2024-03-30T13:45:15.913Z israeli-bank-scrapers:base-scraper-with-browser execute 'postAction' interceptor provided in login options
2024-03-30T13:45:17.916Z israeli-bank-scrapers:base-scraper-with-browser check login result
2024-03-30T13:45:17.919Z israeli-bank-scrapers:base-scraper-with-browser handle login results UNKNOWN_ERROR
2024-03-30T13:45:17.919Z moneyman:scrape [max] LOGIN_FAILED
2024-03-30T13:45:17.919Z israeli-bank-scrapers:base-scraper-with-browser terminating browser with success = false
2024-03-30T13:45:17.919Z moneyman:scrape [max] TERMINATING
2024-03-30T13:45:17.963Z moneyman:scrape [max] END_SCRAPING
2024-03-30T13:45:17.963Z moneyman:scrape error: GENERAL_ERROR Login failed with UNKNOWN_ERROR error
gczobel commented 3 months ago

No time to do it today... but can be easily fixing changing: https://github.com/eshaham/israeli-bank-scrapers/blob/15bcd2645e33c6a44713c04e26a81e193b07d389/src/scrapers/max.ts#L42 to const PASSWORD_EXPIRED_URL = `${BASE_WELCOME_URL}/renew-password`;

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 4.4.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: