search

eshaham / israeli-bank-scrapers

Provide scrapers for all major Israeli banks and credit card companies
MIT License
567 stars 152 forks source link

Behatsdaa scrapper return wrong sign #851

Closed liranelisha closed 2 months ago

liranelisha commented 2 months ago

all expenses made with the Behatsdaa card are returned with positive sign (ex. "230") while every other scrapper is returning a negative sign for expenses (ex. "-230").

all scrappers should return the same sign

baruchiro commented 2 months ago

Do you plan to fix it? Sounds like a tiny change.

liranelisha commented 2 months ago

i had to create a fork from the master as i do not have write permissions. https://github.com/eshaham/israeli-bank-scrapers/pull/852 open, but i don't know if the workflows are on hold due to the fork or something else

baruchiro commented 2 months ago

Yes, although forks are annoying, they are our way to contribute to open source.

You can see how many forks I have just because I wanted to patch something.

liranelisha commented 2 months ago

it seems i had an older version where the sign was wrong