Behatsdaa txns should be positive if expenses, same as the rest of the cards

eshaham / israeli-bank-scrapers

Provide scrapers for all major Israeli banks and credit card companies

MIT License

587 stars 160 forks source link

Behatsdaa txns should be positive if expenses, same as the rest of the cards #852

Closed liranelisha closed 5 months ago

liranelisha commented 5 months ago

closes https://github.com/eshaham/israeli-bank-scrapers/issues/851

This pull request contains a small but significant change in the src/scrapers/behatsdaa.ts file. The variantToTransaction function has been modified to no longer negate the customerPrice when assigning it to originalAmount. This means that the transaction amount will now be represented as a positive value, rather than a negative one.

baruchiro commented 5 months ago

Your change is wrong. As the comment said

The price is positive, make it negative as it's an expense

As you can see, I debugged your change, and it looks like the price is indeed positive, and we need to negate it.

Even while I'm writing this message, I'm confused because issue #851 and this PR are saying the opposite.