search

eshaham / israeli-bank-scrapers

Provide scrapers for all major Israeli banks and credit card companies
MIT License
587 stars 160 forks source link

Dependencies versions & security vulnerabilities #855

Open yanivfranco opened 4 months ago

yanivfranco commented 4 months ago

First, I want say thanks to all the contributors of this project! it is awesome and useful.

The only problem is that most of the dependencies of this repository are SUPER outdated, resulting in lots of security vulnerabilities. This is a big issue when this project is used to access some very sensitive information. Are there any plans on updating the dependencies ?

I noticed this general issue because of a bug with outdated puppeteer.. This is a known issue which is fixed in puppeteer v12 https://github.com/puppeteer/puppeteer/issues/7455 I noticed puppeteer version is 6.0.0, which was release on 2021... and is quite outdated. Is there any reason why the version is not updated? I could maybe try and contribute it myself if there are no objections...

Thanks

baruchiro commented 3 months ago

I have no objections, please try.

yanivfranco commented 3 months ago

@baruchiro I have a PR ready to be pushed, just need the right permissions.... 🙏
before: before

after: after

baruchiro commented 3 months ago

Hi, if it is your first time contributing on Github, you need to fork this repository and open a pull request from your fork to ours.

Read more here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

If you need any help please ask me.

yanivfranco commented 3 months ago

@baruchiro https://github.com/eshaham/israeli-bank-scrapers/pull/862