search

eshaham / israeli-bank-scrapers

Provide scrapers for all major Israeli banks and credit card companies
MIT License
567 stars 152 forks source link

Bank Otsar HaHayal is failing to fetch data #858

Closed ReaBar closed 1 month ago

ReaBar commented 1 month ago

After a successful login, a function tries to verify that the URL is as expected. However, the bank added a new ID to the URL, so this function failed.

The new string ID: Otsar

The function that fails: getKeyByValue .... } else { result = value.toLowerCase() === condition.toLowerCase(); }

ReaBar commented 1 month ago

I saw there is an open PR that needs to be fixed and merged to solve this issue PR @baruchiro can you handle it?

baruchiro commented 1 month ago

You're right.

Can you test the change with the local Jest tests?

ReaBar commented 1 month ago

@baruchiro I'm unfamiliar with jest tests, but I did a local test with the change @matanelgabsi did, and it worked. If you can briefly explain how I run the test suite, I will be glad to be added as a tester to Otsar HaHayal.