search

eshaham / israeli-ynab-updater

A tool for updating YNAB using israeli-bank-scrapers
MIT License
53 stars 15 forks source link

generalize the scraping process to support tasks and currency conversion #30

Closed esakal closed 6 years ago

esakal commented 6 years ago

Setup process

Extended setup process

add new entry point to the library named 'setup' which is needed to support different setup scenarios such as #26 and #28.

Scraping process

Rebranded scraping process

The existing scraping process was rebranded into individual scraping so we will be able to allow scraping either individual scrapers or tasks (#28)

Helpers Added

Settings

a new helper settings.js was added and can be used to read and write into settings.json file.

@eshaham I think you should consider merging this one so both @asfktz and my self will be able to extend the setup process in our other PRs.

esakal commented 6 years ago

@eshaham thanks for reviewing. I pushed a fix to your comments.