search

eshapard / AnkiHabitica

Anki 2.0/2.1 add-on for use with HabitRPG. Automatically scores habits when you reach the end of your Anki timebox and when you review all cards in a deck.
GNU General Public License v3.0
197 stars 31 forks source link

Bar length not increasing correctly with step > 1 #55

Closed eshapard closed 6 years ago

eshapard commented 7 years ago

After the bar reaches about 80%, it will progress twice as fast as it normally does." doesn't happen. It reaches 14 of 18 levels of progress bar normally - each 2 my good answers give 1 tick. And just skips suddenly to the end after that.

This seems to be because the code was not tested much with step > 1

Will adjust make_habit_progbar function to try to account for this.

eshapard commented 7 years ago

Updated code... I think this will fix the issue, but have not tested it.

xavras commented 7 years ago

Seems working now. One more thing - it always make progress on 'step' value of good answers. So if i have step = 2 and reach 80% then after 1st good answer nothing happen. And after 2nd it sets 2 ticks at once. Intuitively progress should be 2x faster, so same amount of pics with 2x less good answers, not 2x more pics with same amount of answers. But it's not really bothering tbh. I don't know if you've ever considered 'solid' progress bar. I think it should work better - visual feedback is immediate no matter what setting you have. And such problems wouldn't exist. And sorry again for mention multiple things in one thread. Fix for bug looks like working :) Thanks for help.

eshapard commented 7 years ago

I did consider a more granular approach, but it would be much harder to implement, and the benefit just doesn't outweigh the increased complexity in my opinion.

On Mon, Sep 18, 2017 at 11:25 AM, Łukasz Rosiek notifications@github.com wrote:

Seems working now. One more thing - it always make progress on 'step' value of good answers. So if i have step = 2 and reach 80% then after 1st good answer nothing happen. And after 2nd it sets 2 ticks at once. Intuitively progress should be 2x faster, so with 2x less good answers. But it's not really bothering tbh. I don't know if you've ever considered 'solid' progress bar. I think it should work better - visual feedback is immediate no matter what setting you have. And such problems wouldn't exist. And sorry again for mention multiple things in one thread. Fix for bug looks like working :) Thanks for help.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eshapard/AnkiHabitica/issues/55#issuecomment-330313524, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5-KtdjNVgtVsW_KJOdxVyHOwELN2Ojks5sjrWzgaJpZM4PbOQM .