search

eshaz / icecast-metadata-js

Browser and NodeJS packages for playing and reading Icecast compatible streaming audio with realtime metadata updates.
155 stars 20 forks source link

[Deprecation] The ScriptProcessorNode is deprecated. Use AudioWorkletNode instead #162

Closed Yahav closed 1 year ago

Yahav commented 1 year ago

Should probably update it for future proofing. https://github.com/eshaz/icecast-metadata-js/blob/57c2bedc99ece498df2591debc637e782f3ac598/src/icecast-metadata-player/src/IcecastMetadataPlayer.js#L554

eshaz commented 1 year ago

This is here so on iOS the AudioContext that's used for WebAudio playback always remains running. Last time I tested, the AudioContext will stop working if this isn't here. If the AudioContext stops, WebAudio playback won't work.

If there's a better way to do this, I would gladly add it in! Closing for now since there's not a better alternative at this time.