Closed jobovy closed 1 year ago
Sorry I let this one slip, can you please update for the newest version?
I merged the latest master
branch, can you approve the workflow runs?
Okay, the tests pass in my fork, so everything's probably fine. I accidentally added some generated files and deleted them again, but you might want to squash and merge this to avoid including that in the history. You might also want to add python 3.10 and 3.11 to the test suite, as a lot of people are probably on 3.10 by now.
Thanks Jo.
Here's a version of the solution I mentioned in https://github.com/esheldon/esutil/pull/76#issuecomment-1145459853, adding a
pyproject.toml
file to havenumpy
available in thesetup.py
file.I also made a few other changes that I think improve the package, but that aren't necessary (the only necessary part is the addition of the
pyproject.toml
file):scipy
to theinstall_requires
argument, because I thinkscipy
, likenumpy
, can now be reliably installed bypip
(I've had it as a dependency for a long time ingalpy
and nobody complains...)numpy
is available insetup.py
, so remove all code to deal with the case where it isn'tminiconda
, but instead just usepip
to install things. This is much faster, ~1 min. vs. 2.5 min. (pip
installs ofnumpy
andscipy
are very fast, becausepip
installs binary wheels). I also moved installs to the relevant section (e.g.,flake8
in the linting step,pytest
in the test step).